Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a Few Compiler Warnings #4290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1eyewonder
Copy link
Contributor

@1eyewonder 1eyewonder commented Jan 30, 2025

Here are a few fixes to some compiler warnings we are getting on builds. I'm wanting to try and go through and attempt to do a few rounds of cleanup to make real issues more obvious when we encounter them.

I'll be making separate PRs for:

  1. InstallModel.CreateFromLibs -> InstallModel.CreateFromContent
    1. There are a lot of warnings we can clean up here
  2. build.fsx
    1. I think we can eliminate a lot of these warnings by updating our FAKE dependencies and referencing the modern core namespaces instead

@smoothdeveloper
Copy link
Contributor

Can you base your PRs on top of #4281?

It already enables warning as errors, while leaving those that are a bit invasive to fix in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants