App Submission: Forgejo #2221

wilddip · 2025-02-18T05:37:52Z

App Submission

App name

Forgejo (#1059)

256x256 SVG icon

Gallery images

Also, my renders https://imgur.com/a/Q7jpLcU

I have tested my app on:

umbrelOS on a Raspberry Pi
umbrelOS on an Umbrel Home
umbrelOS on Linux VM

wilddip · 2025-02-18T05:50:33Z

❌ forgejo/umbrel-app.yml "releaseNotes" needs to be empty for new app submissions:
The "releaseNotes" field must be empty for new app submissions as it is being displayed to the user only in case of an update.

I'm going to ignore it cuz PR containing not the 1.0.0 version. If I'm wrong, correct me, thank you.

github-actions · 2025-02-18T13:43:19Z

❌ Linting failed with 1 error ❌

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity	File	Description
ℹ️	`forgejo/docker-compose.yml`	Mounted file/directory "/forgejo/data/forgejo/data" doesn't exist: The volume "${APP_DATA_DIR}/data/forgejo/data:/var/lib/forgejo" tries to mount the file/directory "/forgejo/data/forgejo/data", but it is not present. This can lead to permission errors!
ℹ️	`forgejo/docker-compose.yml`	Mounted file/directory "/forgejo/data/forgejo/config" doesn't exist: The volume "${APP_DATA_DIR}/data/forgejo/config:/etc/forgejo" tries to mount the file/directory "/forgejo/data/forgejo/config", but it is not present. This can lead to permission errors!
ℹ️	`forgejo/docker-compose.yml`	External port mapping "${APP_FORGEJO_SSH_PORT}:${APP_FORGEJO_SSH_PORT}": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
❌	`forgejo/umbrel-app.yml`	"releaseNotes" needs to be empty for new app submissions: The "releaseNotes" field must be empty for new app submissions as it is being displayed to the user only in case of an update.

Legend

Symbol	Description
❌	Error: This must be resolved before this PR can be merged.
⚠️	Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️	Info: This is just for your information.

al-lac

Hey @wilddip!

Great first submission 🚀

Made some suggestions to make the app fully functional. For example the storage did not work as expected as the data has to be mounted to the gitea folder.

al-lac · 2025-02-19T22:09:19Z

forgejo/docker-compose.yml

+      - db
+
+  db:
+    image: postgres:14@sha256:5d8330e221083215ffbb3c5feeb2cfe44aadda827bc3f0dad9bbf3e58ed2e895


Go for the latest postgres release.

Suggested change

image: postgres:14@sha256:5d8330e221083215ffbb3c5feeb2cfe44aadda827bc3f0dad9bbf3e58ed2e895

image: postgres:17.3@sha256:0321e2252ebfeecb8bc1a899755084d29bce872953e1a5a3e25ec0860b739098

al-lac · 2025-02-19T22:11:23Z

forgejo/docker-compose.yml

+    volumes:
+      - ${APP_DATA_DIR}/data/db:/var/lib/postgresql/data


Add a healthcheck to make sure the db is ready when the app container starts up.

Suggested change

volumes:

- ${APP_DATA_DIR}/data/db:/var/lib/postgresql/data

volumes:

- ${APP_DATA_DIR}/data/db:/var/lib/postgresql/data

healthcheck:

test: ["CMD-SHELL", "pg_isready -U forgejo"]

interval: 5s

timeout: 5s

retries: 5

al-lac · 2025-02-19T22:27:51Z

forgejo/exports.sh

+export APP_FORGEJO_SSH_PORT="2222"
+export APP_FORGEJO_TOR_HS_EXTRA_PORTS="22:forgejo_server_1:${APP_FORGEJO_SSH_PORT}"


Change to a different port to avoid clash with gitea.

Suggested change

export APP_FORGEJO_SSH_PORT="2222"

export APP_FORGEJO_TOR_HS_EXTRA_PORTS="22:forgejo_server_1:${APP_FORGEJO_SSH_PORT}"

export APP_FORGEJO_SSH_PORT="2223"

export APP_FORGEJO_TOR_HS_EXTRA_PORTS="22:forgejo_server_1:${APP_FORGEJO_SSH_PORT}"

al-lac · 2025-02-19T22:28:56Z

forgejo/umbrel-app.yml

+releaseNotes: >-
+  Forgejo v10.0.1 Release Notes (February 8, 2025):
+
+
+  🔒 Security Fixes:
+    - Fixed permissions enforcement for Forgejo Actions web endpoints to prevent unauthorized deletion of runners/variables or modification of variables.
+    - Fixed information leakage in user/organization-wide projects for private repositories.
+    - Added tests to verify the effectiveness of security fixes.
+
+  🎨 User Interface Fixes:
+    - Fixed display of verified icon for default GPG key.
+    - Improved UI for branch selector in commit graph.
+    - Fixed inline file preview for files with encoded URLs.
+
+  🌐 Localization:
+    - Updated translations from Codeberg Translate.
+
+  🐛 Bug Fixes:
+    - Fixed loading settings for valid user and email checks.
+    - Fixed listing tokens without requiring basic auth.
+    - Fixed various UI and functionality issues, including case-insensitive author search and rendering of issue titles.
+
+  🚀 Other Improvements:
+    - Updated dependencies, including Go to v1.23.5 and Katex to v0.16.21.
+    - Improved e2e tests for better reliability.
+
+  For more details, visit the full release notes: https://codeberg.org/forgejo/forgejo/releases/tag/v10.0.1
+


releaseNotes for the first Umbrel app store release should be empty.

Suggested change

releaseNotes: >-

Forgejo v10.0.1 Release Notes (February 8, 2025):

🔒 Security Fixes:

- Fixed permissions enforcement for Forgejo Actions web endpoints to prevent unauthorized deletion of runners/variables or modification of variables.

- Fixed information leakage in user/organization-wide projects for private repositories.

- Added tests to verify the effectiveness of security fixes.

🎨 User Interface Fixes:

- Fixed display of verified icon for default GPG key.

- Improved UI for branch selector in commit graph.

- Fixed inline file preview for files with encoded URLs.

🌐 Localization:

- Updated translations from Codeberg Translate.

🐛 Bug Fixes:

- Fixed loading settings for valid user and email checks.

- Fixed listing tokens without requiring basic auth.

- Fixed various UI and functionality issues, including case-insensitive author search and rendering of issue titles.

🚀 Other Improvements:

- Updated dependencies, including Go to v1.23.5 and Katex to v0.16.21.

- Improved e2e tests for better reliability.

For more details, visit the full release notes: https://codeberg.org/forgejo/forgejo/releases/tag/v10.0.1

releaseNotes: ""

al-lac · 2025-02-19T22:29:17Z

forgejo/umbrel-app.yml

+  For more details, visit the full release notes: https://codeberg.org/forgejo/forgejo/releases/tag/v10.0.1
+
+submitter: John Wilddip
+submission: https://github.com/getumbrel/umbrel-apps/pull/2221


Add final newline (best practice).

Suggested change

submission: https://github.com/getumbrel/umbrel-apps/pull/2221

submission: https://github.com/getumbrel/umbrel-apps/pull/2221

al-lac · 2025-02-19T23:06:03Z

forgejo/docker-compose.yml

+    volumes:
+      - ${APP_DATA_DIR}/data/forgejo/data:/var/lib/forgejo
+      - ${APP_DATA_DIR}/data/forgejo/config:/etc/forgejo


The data and config directory need to be created in the data/forgejo folder. Also the folder where they are mounted to are named gitea in the container.

Suggested change

volumes:

- ${APP_DATA_DIR}/data/forgejo/data:/var/lib/forgejo

- ${APP_DATA_DIR}/data/forgejo/config:/etc/forgejo

volumes:

- ${APP_DATA_DIR}/data/forgejo/data:/var/lib/gitea

- ${APP_DATA_DIR}/data/forgejo/config:/etc/gitea

al-lac · 2025-02-19T23:06:51Z

forgejo/docker-compose.yml

+    depends_on:
+      - db


Wait until db is healthy.

Suggested change

depends_on:

- db

depends_on:

db:

condition: service_healthy

al-lac · 2025-02-19T23:09:19Z

forgejo/docker-compose.yml

+    user: "1000:1000"
+    environment:
+      POSTGRES_USER: forgejo
+      POSTGRES_PASSWORD: forgejo


@nmfretz would it make sense to use $APP_PASSWORD for postgres and other passwords?

wilddip added 2 commits February 18, 2025 05:15

Forgejo v10.0.1

d6c9529

made linting great again

3b936b9

releaseNotes formatting

2f4944f

al-lac suggested changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App Submission: Forgejo #2221

App Submission: Forgejo #2221

wilddip commented Feb 18, 2025 •

edited

Loading

wilddip commented Feb 18, 2025 •

edited

Loading

github-actions bot commented Feb 18, 2025

al-lac left a comment

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

al-lac Feb 19, 2025

	image: postgres:14@sha256:5d8330e221083215ffbb3c5feeb2cfe44aadda827bc3f0dad9bbf3e58ed2e895
	image: postgres:17.3@sha256:0321e2252ebfeecb8bc1a899755084d29bce872953e1a5a3e25ec0860b739098

-    volumes:
-      - ${APP_DATA_DIR}/data/db:/var/lib/postgresql/data
+    volumes:
+      - ${APP_DATA_DIR}/data/db:/var/lib/postgresql/data
+    healthcheck:
+      test: ["CMD-SHELL", "pg_isready -U forgejo"]
+      interval: 5s
+      timeout: 5s
+      retries: 5

		export APP_FORGEJO_SSH_PORT="2222"
		export APP_FORGEJO_TOR_HS_EXTRA_PORTS="22:forgejo_server_1:${APP_FORGEJO_SSH_PORT}"

	submission: https://github.com/getumbrel/umbrel-apps/pull/2221
	submission: https://github.com/getumbrel/umbrel-apps/pull/2221

App Submission: Forgejo #2221

Are you sure you want to change the base?

App Submission: Forgejo #2221

Conversation

wilddip commented Feb 18, 2025 • edited Loading

App Submission

App name

256x256 SVG icon

Gallery images

I have tested my app on:

wilddip commented Feb 18, 2025 • edited Loading

github-actions bot commented Feb 18, 2025

❌ Linting failed with 1 error ❌

Linting Results

Legend

al-lac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wilddip commented Feb 18, 2025 •

edited

Loading

wilddip commented Feb 18, 2025 •

edited

Loading