Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DW_OP_addr is an address, not a .text offset #335

Merged
merged 2 commits into from
Oct 6, 2018
Merged

DW_OP_addr is an address, not a .text offset #335

merged 2 commits into from
Oct 6, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Oct 5, 2018

Fixes #332

@philipc philipc requested a review from fitzgen October 5, 2018 07:40
fitzgen
fitzgen approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We'll have to remember to do a breaking bump on the next release, since this is (of course) a breaking change.

@philipc philipc merged commit 3d15ab8 into gimli-rs:master Oct 6, 2018
@philipc philipc deleted the op branch October 6, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipc @fitzgen