Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Give the actual version number in dep version #1464

Closed
cemremengu opened this issue Dec 19, 2017 · 7 comments
Closed

Give the actual version number in dep version #1464

cemremengu opened this issue Dec 19, 2017 · 7 comments

Comments

@cemremengu
Copy link

cemremengu commented Dec 19, 2017

What version of dep are you using (dep version)?

latest (devel)? This is the issue actually 😄

What dep command did you run?

dep version

What did you expect to see?

> dep version
dep:
 version     :  0.3.2
 build date  :
 git hash    :
 go version  : go1.9
 go compiler : gc
 platform    : windows/amd64

What did you see instead?

> dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.9
 go compiler : gc
 platform    : windows/amd64
@sdboyer
Copy link
Member

sdboyer commented Dec 19, 2017

unfortunately, this is a long standing problem with Go in general - the trick commonly used to report versions in this way don't work when installed via go get.

the best we could do here is to update the OR template to make this clearer to folks filling out issues, so that they know they need to run git describe from the dep repo on their GOPATH.

@calvn
Copy link

calvn commented Dec 31, 2017

The issue also occurs if dep is installed via homebrew.

@frou
Copy link

frou commented Jan 3, 2018

As I understand it, go get clones the HEAD of master. In that case, it wouldn't be accurate for the resultant dep binary to consider itself version 0.3.2 because that version number specifically refers to the state of the repository 184 commits ago...?

@sdboyer
Copy link
Member

sdboyer commented Jan 3, 2018 via email

@calvn
Copy link

calvn commented Jan 3, 2018

Would it make sense if it were to report something like 0.3.2+CHANGES, and under git hash report the particular commit? Right now it's simply reports devel and an empty git hash which makes it hard to determine what version/commit it was built with, unless you go to the src. But even then, that's not deterministic if the repo was pulled and dep has not been re-built.

@frou
Copy link

frou commented Jan 3, 2018 via email

@sdboyer
Copy link
Member

sdboyer commented Jan 26, 2018

Closing, as there's nothing we can directly do here - and once we add #1533, it'll probably be less of an issue, anyway.

@sdboyer sdboyer closed this as completed Jan 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants