-
Notifications
You must be signed in to change notification settings - Fork 1k
Give the actual version number in dep version #1464
Comments
unfortunately, this is a long standing problem with Go in general - the trick commonly used to report versions in this way don't work when installed via go get. the best we could do here is to update the OR template to make this clearer to folks filling out issues, so that they know they need to run |
The issue also occurs if dep is installed via homebrew. |
As I understand it, |
correct. that's why it should be reporting "devel" if you're operating
off a version installed via `go get`.
…On 01/03 10:27, Duncan Holm wrote:
As I understand it, `go get` clones the HEAD of master. In that case, it's not accurate for the resultant dep binary to consider itself version 0.3.2 because that version number specifically refers to the state of the repository 184 commits ago...?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#1464 (comment)
|
Would it make sense if it were to report something like |
The way to inject that kind of information into builds is using `-ldflags` trickery. `go get`, being a simplified workflow, has no awareness of such trickery.
All go-get-able binaries face this same issue so it's not unique to `dep`
… On 3 Jan 2018, at 17:18, Calvin Leung Huang ***@***.***> wrote:
Would it make sense if it were to report something like 0.3.2+CHANGES, and under git hash report the particular commit? Right now it's simply reports devel and an empty git hash which makes it hard to determine what version/commit it was built with, unless you go to the src. But even then, that's not deterministic if the repo was pulled and dep has not been re-built.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closing, as there's nothing we can directly do here - and once we add #1533, it'll probably be less of an issue, anyway. |
What version of
dep
are you using (dep version
)?latest (devel)? This is the issue actually 😄
What
dep
command did you run?dep version
What did you expect to see?
What did you see instead?
The text was updated successfully, but these errors were encountered: