This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
dep ensure
breaks git submodule
#1997
Comments
Ah, i thought i'd kept this behavior in when switching over to the new system for writing out vendor. It would appear not. i'll have a look. We need a small fixup release, anyway. |
benesch
added a commit
to benesch/dep
that referenced
this issue
Sep 5, 2018
The previous code was attempting to copy the .git directory into vendor/vendor/.git, i.e., with an extra level of nesting. It was then failing to notice the error because it was only reporting errors of type *os.LinkError. Fix the bug by removing the layer of nesting and reporting all errors. Fix golang#1997.
Is there a |
lhauspie
pushed a commit
to lhauspie/dep
that referenced
this issue
Apr 9, 2019
The previous code was attempting to copy the .git directory into vendor/vendor/.git, i.e., with an extra level of nesting. It was then failing to notice the error because it was only reporting errors of type *os.LinkError. Fix the bug by removing the layer of nesting and reporting all errors. Fix golang#1997.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of
dep
are you using (dep version
)?v0.5.0
What
dep
command did you run?What did you expect to see?
vendor/.git
preserved.What did you see instead?
The text was updated successfully, but these errors were encountered: