Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

status: add validateFlags() #1330

Merged
merged 2 commits into from
Dec 18, 2017
Merged

Conversation

darkowlzz
Copy link
Collaborator

@darkowlzz darkowlzz commented Oct 30, 2017

What does this do / why do we need it?

Adds flags validation to status command. The validation is based on 2 types of flags:
Operating mode flags: -detailed, -modified, -unused, -missing, -old
Output format flags: -json, -dot, -f

-dot format flag is applicable only to the default status mode.

What should your reviewer look out for in this PR?

Validation logic.

Do you need help or clarification on anything?

No.

Which issue(s) does this PR fix?

None. But preparing for the upcoming different status operating mode implementation.

@darkowlzz darkowlzz force-pushed the status-flag-validation branch 2 times, most recently from 67bc863 to 46eb3bc Compare November 19, 2017 13:41
@darkowlzz darkowlzz force-pushed the status-flag-validation branch from 46eb3bc to 0060bf6 Compare November 21, 2017 14:40
@darkowlzz darkowlzz force-pushed the status-flag-validation branch from 0060bf6 to a4d7ba5 Compare December 6, 2017 17:06
@darkowlzz darkowlzz force-pushed the status-flag-validation branch from a4d7ba5 to 8f6ef14 Compare December 6, 2017 17:07
@sdboyer sdboyer merged commit f2e423e into golang:master Dec 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants