This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fixing an edge case in lockdiff where all the projects may be removed… #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
lockdiff_edgecase
branch
from
5857551 to
9533895
Compare
sdboyer
suggested changes
Aug 2, 2018
gps/verify/lockdiff.go
Outdated
| ProjectAdded: true, | ||
| // Edge case: If there are no lockedProjects on the RHS, they have most probably been removed from the lock file. | ||
| if len(p2) == 0 { | ||
| lpd.ProjectRemoved = true |
There was a problem hiding this comment.
Instead of having to outdent everything under an else statement, let's just put a continue in here.
There was a problem hiding this comment.
Then I'll have to add diff.ProjectDeltas[pr1] = lpd just before the continue. I'll be duplicating it.
There was a problem hiding this comment.
@sdboyer I have updated the PR however. Let me know if the new changes are okay.
… from the lock file.
tariq1890
force-pushed
the
lockdiff_edgecase
branch
from
9533895 to
327682c
Compare
|
@sdboyer I've modified the PR as per your review comment . |
sdboyer
approved these changes
Aug 4, 2018
|
Great, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from the lock file.
What does this do / why do we need it?
Fixes an edge case in the Diff locks case. Never hurts to be too cautious ¯_(ツ)_/¯
What should your reviewer look out for in this PR?
If the changes look okay. Please let me know , If I need to more test cases.
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
#1971