-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflect: add TypeAssert[T] #71639
base: master
Are you sure you want to change the base?
reflect: add TypeAssert[T] #71639
Conversation
10ff4ad
to
b35a231
Compare
This PR (HEAD: b35a231) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-10T15:07:38Z","revision":"22213209ba3888233ea8cf82cac5372c6ae695ba"} Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
This PR (HEAD: eb46a00) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-11T11:34:47Z","revision":"8b4456e086f834a678828b5abf3f4f4fc7606e38"} Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):
Error:
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
This PR (HEAD: e452d77) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-11T13:38:42Z","revision":"4e5f8f42e60d3744eb95f2e0feb24c6072a333e5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
This PR (HEAD: e79e2ea) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/648056. Important tips:
|
Message from Ian Lance Taylor: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-11T17:15:10Z","revision":"679b59c33ef6a9ae28e4227314632fdef56d5e27"} Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Mateusz Poliwczak: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/648056. |
This implementation is zero-alloc, except when a Value is
a method, in that case it allocates.
BenchmarkTypeAssertTime-12 257062033 4.692 ns/op
Fixes #62121