Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/cgo: add assertions for safe stack retrieval on unix #71897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

froz42
Copy link

@froz42 froz42 commented Feb 22, 2025

runtime/cgo: add assertions for safe stack retrieval on Unix

This change introduces assertions (assert()) to verify the return
values of pthread function calls in gcc_stack_unix.c. This improves
error detection and ensures failures in stack attribute retrieval are
caught early.

Changes:

  • Added #include <assert.h> to include the assert() function.
  • Wrapped pthread_attr_init, pthread_getattr_np, pthread_attr_get_np,
    and pthread_attr_getstack calls with assert() to ensure successful
    execution.
  • This change enhances reliability, particularly in cases where these
    functions might fail silently.

Rationale:

  • Ensuring pthread functions execute successfully prevents undefined
    behavior caused by uninitialized or incorrect stack attributes.
  • The use of assert() helps catch errors in debug builds, aiding in
    troubleshooting potential issues early in development.

Testing:

  • Verified that compilation succeeds without warnings or errors.
  • Ensured that assertions do not trigger in normal execution scenarios.
  • Manually tested on supported platforms to confirm expected behavior.

Fixes #71896

Change-Id: Ice10a4b506466e05720d7d45dc609bba75c49109
GitHub-Last-Rev: 0302d11
GitHub-Pull-Request: #71897

@gopherbot
Copy link
Contributor

This PR (HEAD: 0302d11) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/651756.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/651756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/651756.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime/cgo: improve Error Handling in gcc_stack_unix.c with Assertions
2 participants