-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google/externalaccount: support memory CredentialSource for externalaccount package #773
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: dbf83fb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/651575. Important tips:
|
…ccount package This change introduces memory sourced credentials for the google/externalaccount package. This is for credentials that are already in memory and don't need to be loaded from a file or URL. Signed-off-by: Matheus Pimenta <[email protected]>
dbf83fb
to
5d99eb8
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651575. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/651575. |
This PR (HEAD: 5d99eb8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/651575. Important tips:
|
Message from Matheus Pimenta: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651575. |
Message from Matheus Pimenta: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651575. |
Message from Matheus Pimenta: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/651575. |
Fixes #772
This change introduces memory sourced credentials for the
google/externalaccount package. This is for credentials
that are already in memory and don't need to be loaded
from a file or URL.
I have tested this e2e and it works: