Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/goCheck: lintOnSave setting is undefined after function signature change of goLint #1429

Closed
ToothlessGear opened this issue Apr 16, 2021 · 3 comments
Closed

src/goCheck: lintOnSave setting is undefined after function signature change of goLint #1429

ToothlessGear opened this issue Apr 16, 2021 · 3 comments
Assignees
@stamblerre
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.24.2

Comments

@ToothlessGear
Copy link
Contributor

In 0058bd1 a new parameter in the goLint function for goplsConfig has been added, which is not reflected in src/goCheck.ts.

vscode-go/src/goCheck.ts

Line 113 in a9b31d9

goLint(fileUri, goConfig, goConfig['lintOnSave']).then((errors) => ({

This results in an undefined linting scope. No matter what configuration option in settings.json for go.lintOnSave has been selected, it therefore will always fall back to the package scope.

The regression occurs since version 0.24.0.
@gopherbot gopherbot added this to the Untriaged milestone Apr 16, 2021
@heschi heschi modified the milestones: Untriaged, v0.24.1 Apr 16, 2021
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 16, 2021
@heschi heschi modified the milestones: v0.24.1, On Deck Apr 16, 2021
@hyangah hyangah modified the milestones: On Deck, v0.24.2 Apr 16, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/310755 mentions this issue: src/goCheck: add missing goplsConfig parameter to goLint

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/311451 mentions this issue: [release] src/goCheck: add missing goplsConfig parameter to goLint

gopherbot pushed a commit that referenced this issue Apr 19, 2021
@stamblerre @hyangah
[release] src/goCheck: add missing goplsConfig parameter to goLint
d767aa0 
Fixes #1429

Change-Id: I402a29e4dfe95aaa76b8ca852c03c6e3d73eb96c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/310755
Trust: Rebecca Stambler <[email protected]>
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
(cherry picked from commit 10509fb)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/311451
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
@hyangah
Copy link
Contributor

hyangah commented Apr 20, 2021

Fix was released as v0.24.2. Thanks for the report @ToothlessGear !

@golang golang locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stamblerre stamblerre

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.24.2
Development

No branches or pull requests
5 participants
@ToothlessGear @hyangah @stamblerre @gopherbot @heschi