Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict: fix strict type check errors in debug feature implementation #61

Closed
wants to merge 2 commits into from
Closed

strict: fix strict type check errors in debug feature implementation #61

wants to merge 2 commits into from

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented May 16, 2020

Update #57

hyangah added 2 commits May 16, 2020 16:56
@hyangah
strict: src/debugAdapter
e6f80db 
Change-Id: Ib4b13b525130ba8661c236c2b4d3236cac5baeac
@hyangah
strict: src/goDebugConfiguration.ts
1d1e285 
Change-Id: I5fdcf5198755a2868b534af70b4465f2ffcaef0e
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 16, 2020
@hyangah hyangah requested a review from quoctruong May 16, 2020 21:22
@gopherbot
Copy link
Collaborator

This PR (HEAD: 1d1e285) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/234262 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

gerrit bot is not working yet.

Please don’t reply on this GitHub thread. Visit golang.org/cl/234262.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Quoc Truong:

Patch Set 1:

Hi Hana, did you fix this by running an npm command? If so, can you wait until I merge my changes in before running this? There would be a lot of conflicts otherwise.

Please don’t reply on this GitHub thread. Visit golang.org/cl/234262.
After addressing review feedback, remember to publish your drafts!

@hyangah hyangah closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoctruong quoctruong Awaiting requested review from quoctruong

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyangah @gopherbot @googlebot