add func Uint64Map Uint64s #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add func Uint64Map Uint64s
add test uint64s
stevenh
requested changes
Dec 28, 2019
Co-Authored-By: Steven Hartland <[email protected]>
stevenh
approved these changes
Dec 31, 2019
stevenh
requested changes
Dec 31, 2019
|
Hi @xuanskyer could you address the comments above and rebase to fix the conflicts please? |
done |
stevenh
requested changes
Apr 13, 2020
There was a problem hiding this comment.
Thanks for the update @xuanskyer few more things with the update and one I missed when I initially reviewed, sorry about that.
|
I think you forgot to push the update there @xuanskyer |
stevenh
requested changes
Apr 15, 2020
redis/reply.go
Outdated
| @@ -479,6 +479,55 @@ func Positions(result interface{}, err error) ([]*[2]float64, error) { | |||
| return positions, nil | |||
| } | |||
|
|
|||
| // Uint64s is a helper that converts an array command reply to a []uint64. | |||
| //If err is not equal to nil, then Uint64s returns nil, err. Nil array | |||
There was a problem hiding this comment.
Suggested change
| //If err is not equal to nil, then Uint64s returns nil, err. Nil array | |
| // If err is not equal to nil, then Uint64s returns nil, err. Nil array |
stevenh
requested changes
Apr 15, 2020
There was a problem hiding this comment.
Thanks @xuanskyer almost there, you just missed the doc comment fix, so I've added it again so you can just click 'Commit suggestion'.
Co-Authored-By: Steven Hartland <[email protected]>
pull bot
pushed a commit
to scope-demo/redigo
that referenced
this pull request
Apr 16, 2020
Add two additional help functions that handle uint64 data types: * Uint64Map * Uint64s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add func Uint64Map Uint64s