feat: Add TLS Handshake timeout support #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
changed the title
Add support for configuring a timeout for TLS Handshake call via DialTLSHandshakeTimeout DialOption. If no option is specified then the default timeout is 10 seconds. Also: * Add a default connect timeout of 30 seconds matching that of net/http. Fixes #509
mdanzinger
approved these changes
Nov 5, 2020
danmrichards
reviewed
Nov 5, 2020
Co-authored-by: Dan Richards <[email protected]>
Cleanup timer defer to avoid second test and document reasons for buffered channel.
|
@danmrichards I have cleaned up the timer cleanup in a slightly different way, could you re-review please. |
danmrichards
approved these changes
Nov 14, 2020
|
great, thanks for adding this! it would be nice to have a new tag published some time soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuring a timeout for TLS Handshake call via DialTLSHandshakeTimeout DialOption. If no option is specified then the default timeout is 10 seconds.
Also:
Fixes #509