feat: add RequestContext to PubSubConn #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
commented
Mar 17, 2022
pabigot
added a commit
to pabigot/redigo
that referenced
this pull request
Mar 17, 2022
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
bf087ba to
7a12a16
Compare
pabigot
added a commit
to pabigot/redigo
that referenced
this pull request
Mar 17, 2022
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
7a12a16 to
c6262f1
Compare
|
It doesn't seem that the design intent is to limit the features of PubSubConn, but an alternative approach that's only slightly less ideal would be to expose That might be useful anyway. |
pabigot
changed the title
pabigot
added a commit
to pabigot/redigo
that referenced
this pull request
Mar 22, 2022
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
c6262f1 to
4e84dfc
Compare
stevenh
requested changes
Mar 23, 2022
pabigot
added a commit
to pabigot/redigo
that referenced
this pull request
Mar 23, 2022
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
4e84dfc to
3706d8e
Compare
pabigot
added a commit
to pabigot/redigo
that referenced
this pull request
Mar 23, 2022
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
3706d8e to
72f6445
Compare
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: gomodule#592
pabigot
force-pushed
the
pabigot/20220317a
branch
from
72f6445 to
ad7e9d2
Compare
stevenh
approved these changes
Mar 23, 2022
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper that goes through the standard receiveInternal
processing to match the API of the existing PubSubConn Receive
methods.
Fixes: #592