Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS/JS] Upgrade dependencies #7996

Merged
merged 14 commits into from
Dec 14, 2023

Conversation

bjornharrtell
Copy link
Collaborator

No description provided.

@bjornharrtell
Copy link
Collaborator Author

buildkite failure looks something along:

(16:11:15) ERROR: /workdir/ts/BUILD.bazel:22:11: //ts:_validate_flatbuffers_ts_options depends on @npm_typescript//:validator in repository @npm_typescript which failed to fetch. no such package '@npm_typescript//': java.io.IOException: Error downloading [https://registry.npmjs.org/typescript/-/typescript-5.1.3.tgz] to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/npm_typescript/temp3992301124588390917/typescript-5.1.3.tgz: Checksum was 5c7eb6ec4f6f91eaa1959150b8bf94b3201712789b4f491647615638d96be2c4e3bf1c89627c9e7e0ae4c8408bccce4d7a798acd1032dab47f3a560b0351e467 but wanted 716f53e56f71637edc73e8df127694bd7f757e8c6d1e4cdadcdc37c24a05e2c4a52a7d0c38d7647449dd8a0fea3c15973649a9961dcdcdac90cc2887338fe1ab

@dbaileychess likely something tiny that needs tweaking to get this to work but I'm the dark.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 3 weeks with no activity. Please comment or label not-stale, or this will be closed in 7 days.

@github-actions github-actions bot added stale and removed stale labels Jun 28, 2023
@bjornharrtell
Copy link
Collaborator Author

bjornharrtell commented Aug 21, 2023

Now I see:

Error in fail: npm_translate_lock currently supports a maximum lock_version of 6.0, but found 6.1. Please file an issue on rules_js
  | ERROR: no such package '@npm//': npm_translate_lock currently supports a maximum lock_version of 6.0, but found 6.1. Please file an issue on rules_js

Which seems to be fixed at aspect-build/rules_js#1090. So should attempt to upgrade rules_js.. however, I fail to understand how that is done.

@bjornharrtell bjornharrtell force-pushed the feature/ts-js-deps-up branch from 759bb6e to af92c04 Compare August 27, 2023 16:02
@bjornharrtell bjornharrtell enabled auto-merge (squash) August 28, 2023 07:35
@bjornharrtell
Copy link
Collaborator Author

@dbaileychess I belive this is good to merge now.

@bjornharrtell bjornharrtell merged commit 6dfc59d into google:master Dec 14, 2023
@bjornharrtell bjornharrtell deleted the feature/ts-js-deps-up branch December 14, 2023 06:14
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants