Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes 'size' and 'alignment' as Rust keywords #8139

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Removes 'size' and 'alignment' as Rust keywords #8139

merged 2 commits into from
Nov 12, 2024

Conversation

csmulhern
Copy link
Contributor

Fixes #8114.

@github-actions github-actions bot added c++ rust codegen Involving generating code from schema labels Oct 30, 2023
@csmulhern csmulhern mentioned this pull request Oct 30, 2023
Closed
CasperN
CasperN previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@CasperN CasperN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - are you good to push on green?

@CasperN
Copy link
Collaborator

CasperN commented Oct 31, 2023

Oh, looks like tests caught something. FYI Rust tests are intests/rust_usage_test/...

@csmulhern
Copy link
Contributor Author

Oh, looks like tests caught something. FYI Rust tests are intests/rust_usage_test/...

Thanks. Hopefully fixed now.

@csmulhern
Copy link
Contributor Author

LGTM - are you good to push on green?

👍

@csmulhern
Copy link
Contributor Author

@CasperN looks like I need approval for some workflows.

@csmulhern
Copy link
Contributor Author

@CasperN any update here?

@csmulhern
Copy link
Contributor Author

csmulhern commented Mar 23, 2024 •
edited
Loading

Any update here? @dextero, @adsnaider, any idea who can review this? @CasperN seems to be inactive at this time.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 24, 2024
@csmulhern
Copy link
Contributor Author

This is not stale. I'm waiting for anyone who can approve to look at this.

@github-actions github-actions bot removed the stale label Sep 30, 2024
@csmulhern
Copy link
Contributor Author

@dbaileychess @aardappel, any chance I can get a review on this?

@aardappel
Copy link
Collaborator

Not familiar enough with Rust, but since @CasperN was ok with this change, will merge once CI completes.

@aardappel aardappel enabled auto-merge (squash) November 11, 2024 18:27
aardappel
aardappel previously approved these changes Nov 11, 2024
View reviewed changes
auto-merge was automatically disabled November 11, 2024 23:02

Head branch was pushed to by a user without write access

@csmulhern
Copy link
Contributor Author

Thanks. I had to regenerate one stale file (tests/rust_namer_test/rust_namer_test/possibly_reserved_words_generated.rs). I think all tests should pass now.

@aardappel aardappel enabled auto-merge (squash) November 12, 2024 05:09
@aardappel aardappel merged commit 5f453ef into google:master Nov 12, 2024
90 of 92 checks passed
razvanalex pushed a commit to razvanalex/flatbuffers that referenced this pull request Dec 3, 2024
@csmulhern @razvanalex
Removes 'size' and 'alignment' as Rust keywords (google#8139)
9dd3f03 
* Adds fields for possibly reserved words to rust_namer_test

* Removes size and alignment as rust reserved words
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2024
Merged
@a10y a10y mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aardappel aardappel aardappel approved these changes

@CasperN CasperN CasperN left review comments

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing 'size' and 'alignment' as Rust keywords
3 participants
@csmulhern @CasperN @aardappel