-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift] Sets Swift minimum support to 5.8 #8228
[Swift] Sets Swift minimum support to 5.8 #8228
Conversation
7360121
to
d80f7ee
Compare
163ae57
to
1f51a4c
Compare
@keith I've been looking at the Bazel ci and it seems that we do not build the swift package in Bazel when it's macOS, correct me if I am wrong here. |
755af8c
to
8e492b3
Compare
e3eaeb0
to
48a952a
Compare
hrm i feel like the intent of my change in the .bazelci/presubmit.yml in https://github.com/google/flatbuffers/pull/7195/files was to make sure we were building it on that CI. but I don't see it in the log on this change https://buildkite.com/bazel/flatbuffers/builds/9334#018e36a4-9b4e-4cd6-b699-167c8fb9707c |
I was looking into |
I don't see it either, but I think it should be there and we should try to fix that. The iOS app store requires using Xcode 15+ now even, so I think we'd want to verify it builds successfully with that |
If that's the case, maybe we should add another test to bazel just for Xcode 15+ and swift. While keeping the current Bazel set to Xcode 14.2/3. And I guess Swift version should be 5.8 instead of 5.7. We just need to fix the bazel CI for both cpp and swift. |
48a952a
to
150d6a9
Compare
150d6a9
to
c223ff5
Compare
Updates copyright from 2023 to 2024 & formats code - updates formatting rules Updates CI to run with swift 5.8 Adds wasmer & updates command to run carton as a swift plugin Update bazelci to also accept swift 5.8 Adds swift 5.10 to the test matrix
db3daa5
to
11649ae
Compare
@dbaileychess how can we move forward with this PR? |
Sure. We probably don't need to update the copyright dates in the file, but it is not harming anything. |
Updates copyright from 2023 to 2024 & formats code - updates formatting rules Updates CI to run with swift 5.8 Adds wasmer & updates command to run carton as a swift plugin Update bazelci to also accept swift 5.8 Adds swift 5.10 to the test matrix
Updates copyright from 2023 to 2024 & formats code - updates formatting rules Updates CI to run with swift 5.8 Adds wasmer & updates command to run carton as a swift plugin Update bazelci to also accept swift 5.8 Adds swift 5.10 to the test matrix
The following PR updates dependencies since swift 6 is going to be out soon, and now we replaces the minimum version to 5.8.
Depends on #8304