Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Sets Swift minimum support to 5.8 #8228

Merged
merged 2 commits into from
May 29, 2024

Conversation

mustiikhalil
Copy link
Collaborator

@mustiikhalil mustiikhalil commented Feb 3, 2024

The following PR updates dependencies since swift 6 is going to be out soon, and now we replaces the minimum version to 5.8.

  • Drops support for swift 5.5, 5.6, 5.7
  • Updates carton dependencies for SwiftWasm
  • Updates copyright from 2023 to 2024 & formats code - updates formatting rules

Depends on #8304

@mustiikhalil mustiikhalil self-assigned this Feb 3, 2024
@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch from 7360121 to d80f7ee Compare March 12, 2024 00:09
@mustiikhalil mustiikhalil changed the title [Swift] formatting & copyright updates [Swift] Sets Swift minimum support to 5.8 Mar 12, 2024
@github-actions github-actions bot added the CI Continuous Integration label Mar 12, 2024
@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch 4 times, most recently from 163ae57 to 1f51a4c Compare March 12, 2024 01:31
@mustiikhalil
Copy link
Collaborator Author

@keith I've been looking at the Bazel ci and it seems that we do not build the swift package in Bazel when it's macOS, correct me if I am wrong here.

@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch from 755af8c to 8e492b3 Compare March 13, 2024 06:54
@mustiikhalil mustiikhalil changed the title [Swift] Sets Swift minimum support to 5.8 [Swift] Sets Swift minimum support to 5.7 Mar 13, 2024
@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch 2 times, most recently from e3eaeb0 to 48a952a Compare March 13, 2024 07:08
@keith
Copy link
Contributor

keith commented Mar 20, 2024

hrm i feel like the intent of my change in the .bazelci/presubmit.yml in https://github.com/google/flatbuffers/pull/7195/files was to make sure we were building it on that CI. but I don't see it in the log on this change https://buildkite.com/bazel/flatbuffers/builds/9334#018e36a4-9b4e-4cd6-b699-167c8fb9707c

@mustiikhalil
Copy link
Collaborator Author

I was looking into master and it seems that it's not running there too https://buildkite.com/bazel/flatbuffers/builds/9318#018e3007-cdc6-4c77-8f11-f03d312d4e20 or am I missing something? and It seems that we can't update our support to only use Xcode 14.3 because of the gRPC lib that we use as seen here: 67eb95d

@keith
Copy link
Contributor

keith commented Mar 21, 2024

I don't see it either, but I think it should be there and we should try to fix that. The iOS app store requires using Xcode 15+ now even, so I think we'd want to verify it builds successfully with that

@mustiikhalil
Copy link
Collaborator Author

If that's the case, maybe we should add another test to bazel just for Xcode 15+ and swift. While keeping the current Bazel set to Xcode 14.2/3. And I guess Swift version should be 5.8 instead of 5.7. We just need to fix the bazel CI for both cpp and swift.

@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch from 48a952a to 150d6a9 Compare May 11, 2024 20:17
@mustiikhalil mustiikhalil changed the title [Swift] Sets Swift minimum support to 5.7 [Swift] Sets Swift minimum support to 5.8 May 11, 2024
@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch from 150d6a9 to c223ff5 Compare May 29, 2024 05:30
Updates copyright from 2023 to 2024 & formats code - updates formatting rules

Updates CI to run with swift 5.8

Adds wasmer & updates command to run carton as a swift plugin

Update bazelci to also accept swift 5.8

Adds swift 5.10 to the test matrix
@mustiikhalil mustiikhalil force-pushed the mmk/update-copyright-swift branch from db3daa5 to 11649ae Compare May 29, 2024 05:38
@mustiikhalil
Copy link
Collaborator Author

@dbaileychess how can we move forward with this PR?

@dbaileychess
Copy link
Collaborator

Sure. We probably don't need to update the copyright dates in the file, but it is not harming anything.

@dbaileychess dbaileychess merged commit 75f05d6 into google:master May 29, 2024
48 checks passed
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Updates copyright from 2023 to 2024 & formats code - updates formatting rules

Updates CI to run with swift 5.8

Adds wasmer & updates command to run carton as a swift plugin

Update bazelci to also accept swift 5.8

Adds swift 5.10 to the test matrix
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Updates copyright from 2023 to 2024 & formats code - updates formatting rules

Updates CI to run with swift 5.8

Adds wasmer & updates command to run carton as a swift plugin

Update bazelci to also accept swift 5.8

Adds swift 5.10 to the test matrix
@mustiikhalil mustiikhalil deleted the mmk/update-copyright-swift branch November 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration grpc swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants