Go set []byte capacity on Table ByteVector #8529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated data when appending to returned slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the capacity==length on slices returned from Table.ByteVector the integrity of the Table is preserved if appends are made beyond the length of the returned slice. I.e. now it will force a reallocation rather than overwriting unrelated fields in the Table.
This is especially useful when using the Object API with a Table containing 2 or more []byte fields. Depending on the order of building appending to fields "earlier" in the table can modify other fields in the struct which is probably surprising as other types have been deep copied from the original serialised Table.