linalg-to-tensor-ext: reorder kernel lowering to avoid plaintext/ciphertext type issues #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_726472644
branch
from
c1b073f to
e71f9da
Compare
copybara-service
bot
force-pushed
the
test_726472644
branch
4 times, most recently
from
1497b6f to
b1535a2
Compare
j2kun
approved these changes
Feb 19, 2025
copybara-service
bot
force-pushed
the
test_726472644
branch
from
b1535a2 to
f46684f
Compare
copybara-service
bot
force-pushed
the
test_726472644
branch
from
f46684f to
6b8f58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linalg-to-tensor-ext: reorder kernel lowering to avoid plaintext/ciphertext type issues
I don't think there's a way to avoid this - I moved final computations outside of the loop to be before the loop, so that the iter_arg of the loop can be a ciphertext type to match with the yielded ciphertext type.
Before, the iter_arg of the loop was the initial bias, a plaintext type, which meant that we had a type issue at secret-to-ckks since the iter arg of a for loop must match the yielded type (which will become a ciphertext once the partial matmul result is added to it)
Related to #1338