feat: navigation compose and delegation pattern #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the Navigation SDK to Maps Compose. It just allows the user to replace a standard MapView with a NavigationView within a GoogleMap composable. The following changes were made: Added a new NavigationViewDelegate class to handle the integration between NavigationView and Maps Compose. Added a new NavigationScreen composable function to display the navigation view. Added a new MovableMarker composable function to display a draggable marker on the map. Updated the GoogleMap composable function to support the use of NavigationView. Added a new NavigationApplication class to initialize the Places SDK. Added a new ApiKeyProvider class to provide API keys for the Maps and Places SDKs. Added a new LocationProvider class to provide location data. Added a new PermissionChecker class to check for location permissions. Updated the build.gradle.kts files to include the necessary dependencies. Updated the local.defaults.properties file to include the Places API key.
Adds NavigationViewDelegate to support NavigationView in the navigation sample app. This change allows the navigation sample app to use NavigationView, which provides turn-by-turn navigation functionality. The NavigationViewDelegate handles the lifecycle and rendering of the NavigationView, ensuring that it is properly integrated into the Jetpack Compose UI. Uses a MarkerComposable to demonstrate the map really is a composable
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Code Coverage
|
kikoso
reviewed
Jan 13, 2025
maps-compose/src/main/java/com/google/maps/android/compose/MapComposeViewRender.kt
Show resolved
Hide resolved
kikoso
reviewed
Jan 13, 2025
|
|
||
| override fun onLowMemory() { | ||
| // TODO(): what is the correct value here? | ||
| mapView.onTrimMemory(ComponentCallbacks2.TRIM_MEMORY_COMPLETE) |
There was a problem hiding this comment.
There does not seem to be any reference to which value is the correct one, given that all of them are deprecated. The method does not really seem to be documented.
There was a problem hiding this comment.
Just removed the TODO since it is not actionable.
kikoso
reviewed
Jan 13, 2025
| @@ -145,19 +150,31 @@ public fun GoogleMap( | |||
| var subcompositionJob by remember { mutableStateOf<Job?>(null) } | |||
| val parentCompositionScope = rememberCoroutineScope() | |||
|
|
|||
| var delegate by remember { | |||
| // TODO: this could leak the view? | |||
There was a problem hiding this comment.
My two cents: if the AbstractMapViewDelegate is holding a reference to the Context it could leak. But I think we are directly not doing it, if we take a look at the mapViewDelegate, right? Not sure if using the java.lang.ref.WeakReference will make sense.
EDIT: Yeah, I think we are holding a reference in this file.
kikoso
reviewed
Jan 13, 2025
...ation-app/src/main/java/com/google/maps/android/compose/navigation/NavigationViewDelegate.kt
Show resolved
Hide resolved
kikoso
force-pushed
the
navigation-compose
branch
from
d3c6162 to
934fee6
Compare
Adds support for the Navigation SDK to Maps Compose. It just allows the user to replace a standard MapView with a NavigationView within a GoogleMap composable. The following changes were made: Added a new NavigationViewDelegate class to handle the integration between NavigationView and Maps Compose. Added a new NavigationScreen composable function to display the navigation view. Added a new MovableMarker composable function to display a draggable marker on the map. Updated the GoogleMap composable function to support the use of NavigationView. Added a new NavigationApplication class to initialize the Places SDK. Added a new ApiKeyProvider class to provide API keys for the Maps and Places SDKs. Added a new LocationProvider class to provide location data. Added a new PermissionChecker class to check for location permissions. Updated the build.gradle.kts files to include the necessary dependencies. Updated the local.defaults.properties file to include the Places API key.
Adds NavigationViewDelegate to support NavigationView in the navigation sample app. This change allows the navigation sample app to use NavigationView, which provides turn-by-turn navigation functionality. The NavigationViewDelegate handles the lifecycle and rendering of the NavigationView, ensuring that it is properly integrated into the Jetpack Compose UI. Uses a MarkerComposable to demonstrate the map really is a composable
… into navigation-compose
kikoso
changed the title
kikoso
reviewed
Feb 20, 2025
|
|
||
| configurations.all { | ||
| resolutionStrategy { | ||
| exclude(group = "com.google.android.gms", module = "play-services-maps") |
There was a problem hiding this comment.
TODO: add a small comment about why we are doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕