Fix bug where FileSystem.Path.join didn't respect root of first path.

gren-lang · Feb 10, 2025 · 7d50834 · 7d50834
1 parent 0bf6451
commit 7d50834
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/src/FileSystem/Path.gren b/src/FileSystem/Path.gren
@@ -180,4 +180,9 @@ prepend left right =
 -}
 join : Array Path -> Path
 join paths =
-    Array.foldl append (fromPosixString ".") paths
+    when Array.popFirst paths is
+        Just { first, rest } ->
+            Array.foldl append first rest
+
+        Nothing ->
+            empty
diff --git a/tests/src/Test/FileSystemPath.gren b/tests/src/Test/FileSystemPath.gren
@@ -145,8 +145,14 @@ tests =
                         |> Path.append (Path.fromPosixString "/with/more")
                         |> Path.toPosixString
                         |> Expect.equal "/some/longer/file.md/with/more"
+            , test "Preserves root" <|
+                \{} ->
+                    Path.fromPosixString "/some/path"
+                        |> Path.append (Path.fromPosixString "nested/file.md")
+                        |> Path.toPosixString
+                        |> Expect.equal "/some/path/nested/file.md"
             ]
-        , describe "concat"
+        , describe "join"
             [ test "Easier way to join many paths" <|
                 \{} ->
                     Expect.equal
@@ -160,5 +166,15 @@ tests =
                             , Path.fromPosixString "/file.md"
                             ]
                         )
+            , test "Preserves root" <|
+                \{} ->
+                    Expect.equal
+                        (Path.fromPosixString "/my/long/path/to/file.md")
+                        (Path.join
+                            [ Path.fromPosixString "/my/long"
+                            , Path.fromPosixString "path/to"
+                            , Path.fromPosixString "file.md"
+                            ]
+                        )
             ]
         ]