Improve Swiss public transport #30715
Conversation
Those information are available from OpendataTransport object, so no need to pass it to the sensor separately.
Add a list of all upcomming connections. Also make the count of connections configureable through a new config parameter "limit". This can be useful for custom lovelace cards which display more than one connection.
The Swiss public transport API supports stationboard type requests to get all departing connections from a given station. Add this type of sensor to the swiss_public_transport integration. This is especially useful for smaller train or bus station to just display when the next departure is and whether the departure is delayed.
agners
force-pushed
the
swiss-public-transport-improvements
branch
from
ba08d0c to
b1e311f
Compare
| async def async_setup_platform(hass, config, async_add_entities, discovery_info=None): | ||
| """Set up the Swiss public transport sensor.""" | ||
|
|
||
| name = config.get(CONF_NAME) | ||
| start = config.get(CONF_START) | ||
| destination = config.get(CONF_DESTINATION) | ||
| stationboard = config.get(CONF_STATIONBOARD) | ||
| limit = config.get(CONF_LIMIT, 5) |
There was a problem hiding this comment.
The default should be set in the validation -> vol.Optional(CONF_LIMIT, default=5): cv.positive_int,
| vol.Optional(CONF_DESTINATION): cv.string, | ||
| vol.Optional(CONF_START): cv.string, | ||
| vol.Optional(CONF_STATIONBOARD): vol.All(cv.ensure_list, [cv.string]), | ||
| vol.Optional(CONF_LIMIT): cv.positive_int, |
There was a problem hiding this comment.
We should work with vol.Inclusive/vol.Exclusive here. Like CONF_START and CONF_DESTINATION together.
Perhaps it could make sense to combine CONF_START and CONF_STATIONBOARD and if the CONF_DESTINATION is not given show the stationboard.
This is a breaking change but that's inevitable.
|
|
||
| async def async_update(self): | ||
| """Get the latest data from opendata.ch and update the states.""" | ||
| _LOGGER.info("async_update called") |
There was a problem hiding this comment.
Looks like something that is only useful for developing.
| @@ -103,6 +186,9 @@ def device_state_attributes(self): | |||
| self._opendata.connections[0]["departure"] | |||
| ) - dt_util.as_local(dt_util.utcnow()) | |||
|
|
|||
| # Convert to a list since this is more approprate | |||
| connections = [c[1] for c in sorted(self._opendata.connections.items())] | |||
There was a problem hiding this comment.
Please use proper variable name aka not c.
| """Initialize the sensor.""" | ||
| self._opendata = opendata | ||
| self._name = name | ||
| self._remaining_time = "" |
There was a problem hiding this comment.
| self._remaining_time = "" | |
| self._remaining_time = None |
springstan
changed the title
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Description:
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11722
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: