Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils/cookie): Ability to set a priority to cookies in setCookie options #3762

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

Beyondo
Copy link
Contributor

@Beyondo Beyondo commented Dec 22, 2024

Hono's setCookie did not have Priority and I recently needed that option so I forked hono and added it. Nothing's serious been changed—succesfully tested locally.

@EdamAme-x
Copy link
Contributor

It may be necessary to write a simple test on this.

@Beyondo
Copy link
Contributor Author

Beyondo commented Dec 22, 2024

It may be necessary to write a simple test on this.

My bad—added priority to the seralization tests (3f0e470):

...
 ✓ src/utils/cookie.test.ts (27)
...
 Test Files  9 passed (9)
      Tests  414 passed | 3 skipped (417)
...

@yusukebe yusukebe changed the title Ability to set a priority to cookies in setCookie options feat(utils/cookie): Ability to set a priority to cookies in setCookie options Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (4eb101d) to head (3f0e470).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/cookie.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         159      159              
  Lines       10178    10182       +4     
  Branches     2896     2870      -26     
==========================================
+ Hits         9336     9339       +3     
- Misses        841      842       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @Beyondo

Thank you for the PR. Looks good. I'll merge this later and induce this change in the next patch release.

@yusukebe
Copy link
Member

Now, the time has come. I'll merge it.

@yusukebe yusukebe merged commit fd6e5bd into honojs:main Dec 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants