fix(node-ws): allow Hono with custom Env for createNodeWebSocket
#951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1cf980 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yusukebe
changed the title
Hono with custom EnvHono with custom Env for createNodeWebSocket
|
Hey @nakasyou ! Can you review this? |
|
It looks good! |
|
@nakasyou Thanks!
No. It's for just removing the type error. We may add the Bindigns/Variables type to the first arg |
|
Anyway, I'll merge this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
Hono<any, any, any>can accept an app with custom Bindings/Variables types. This method is used in such the code:https://github.com/honojs/hono/blob/093d3fd56ea4411aab305984dbc29e24ac3ac528/src/client/client.ts#L122
The author should do the following, if applicable
yarn changesetat the top of this repo and push the changeset