Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Support new prerelease scheme #170

Closed
3 tasks done
carolynvs opened this issue Aug 16, 2017 · 2 comments
Closed
3 tasks done

🔥 Support new prerelease scheme #170

carolynvs opened this issue Aug 16, 2017 · 2 comments
Assignees

Comments

@carolynvs
Copy link
Collaborator

carolynvs commented Aug 16, 2017

Prereleases are no longer consistently listed in the github tags/releases. So attempts to install 17.07.0-ce-rc1 fails because it's not "official" but the binaries do exist under https://download.docker.com/mac/static/test/x86_64/.

  • Since they are cutting releases without tagging, we need to stop validating a version by looking it up on github. The true test of if a version exists is if the binary is present. Never check a version before installing #181
  • We need to fix dvm list-remote --pre to list what's in the test releases directory. I think it's safe at this point to not list older prereleases from the original download location. Fix ls-remote #182
  • Check for versions first in stable when installing, and fall back to test (see comment below).
@carolynvs carolynvs changed the title Support new prerelease scheme 🔥 Support new prerelease scheme Aug 16, 2017
@carolynvs carolynvs self-assigned this Aug 16, 2017
@carolynvs
Copy link
Collaborator Author

carolynvs commented Oct 19, 2017

Prereleases no longer always have the -rc suffix anymore. So we do see a version like 17.10.0-ce in the prerelease location, and eventually when it is "finalized", it is published to the stable location (the old test release is not removed, but should no longer be used once a stable release is available). 🤦‍♀️

@carolynvs
Copy link
Collaborator Author

Fixed by #182, #183, and #181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant