Retry failed release downloads from test location #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realize these are only useful tests at this point in time, but the test matrix is so complex, it's worth it for now.
carolynvs
force-pushed
the
install-fallback-location
branch
from
638f27a to
6822c4b
Compare
* Move logic for downloading versions directly into the version struct * When downloading a non-prerelease version, if it fails, check if it's available on the test location. 😆
Now that we don't check the version up-front, we need better messages/handling when the version is bad.
carolynvs
force-pushed
the
install-fallback-location
branch
from
c83a337 to
b326b11
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker publishes releases that don't have a prerelease suffix (e.g.
-rc) to the test location (look in https://download.docker.com/mac/static/test/x86_64/ and you'll see17.10.0-ce). Then some time later, when the version is ready for a final release, they publish a new release with the same version to the stable location.Since we can't tell where to find a version based on its value anymore, first try downloading from stable, then if that fails, check if there's a test release available.
Related to #170.