Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #191

Merged
merged 4 commits into from
Dec 31, 2018
Merged

Fix build #191

merged 4 commits into from
Dec 31, 2018

Conversation

carolynvs
Copy link
Collaborator

@carolynvs carolynvs commented Dec 30, 2018

  • test.docker.com has been removed by Docker and replaced with a download script. I don't know where you can even file those files anymore. ¯_(ツ)_/¯. I'm keeping the tests commented out in case anyone wants to go spleunking. But mostly to vent some spleen. 😀
  • Fix a vet error that is making the build fail
  • Updated one of the tests to use a version of docker that is still available

@carolynvs
Copy link
Collaborator Author

@rgbkrk When you have time, can you review and merge this one first? It fixes tests that run during CI. Once the build is green, we can safely test and merge the other PRs.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 31, 2018

You'll have to add me to the org in order for me to merge this. 😄

@carolynvs
Copy link
Collaborator Author

You'll have to add me to the org in order for me to merge this.

Challenge Accepted!

@rgbkrk
Copy link
Member

rgbkrk commented Dec 31, 2018

I can still only comment 😅

Looking at the permissions, I think you'll have to either add me to the repo as a collaborator or make a team that has access to this repo.

@carolynvs
Copy link
Collaborator Author

Okay how about now? I made a team called @howtowhale/dvm-maintainers and made you a captain. ⚓️

@rgbkrk rgbkrk merged commit 0d08443 into howtowhale:master Dec 31, 2018
@rgbkrk
Copy link
Member

rgbkrk commented Dec 31, 2018

All set! Thanks for having me aboard.

@carolynvs
Copy link
Collaborator Author

Yaarrrrrrr, thanks for merging!

@carolynvs carolynvs deleted the fix-build branch January 1, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants