-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build #191
Fix build #191
Conversation
carolynvs
commented
Dec 30, 2018
•
edited
Loading
edited
- test.docker.com has been removed by Docker and replaced with a download script. I don't know where you can even file those files anymore. ¯_(ツ)_/¯. I'm keeping the tests commented out in case anyone wants to go spleunking. But mostly to vent some spleen. 😀
- Fix a vet error that is making the build fail
- Updated one of the tests to use a version of docker that is still available
@rgbkrk When you have time, can you review and merge this one first? It fixes tests that run during CI. Once the build is green, we can safely test and merge the other PRs. |
You'll have to add me to the org in order for me to merge this. 😄 |
Challenge Accepted! |
I can still only comment 😅 Looking at the permissions, I think you'll have to either add me to the repo as a collaborator or make a team that has access to this repo. |
Okay how about now? I made a team called @howtowhale/dvm-maintainers and made you a captain. ⚓️ |
All set! Thanks for having me aboard. |
Yaarrrrrrr, thanks for merging! |