Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add layout mapping API for external plugins #1093

Merged
merged 6 commits into from
Apr 26, 2024
Merged

add layout mapping API for external plugins #1093

merged 6 commits into from
Apr 26, 2024

Conversation

therealdreg
Copy link
Collaborator

@therealdreg therealdreg commented Apr 23, 2024 •
edited
Loading

Description

This fixes all the issues with the context panes and it now works as it did before the plugins were created.

In the GEF part, it was just a minor refactor and a new external API.

In the gef-extras part, it was only necessary to call this new function!

I think the proposed solution is simple and it works.

gef-extras code:

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@therealdreg therealdreg mentioned this pull request Apr 23, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

🤖 Coverage update for 54adb74 🟢

Old New
Commit 8031fda 54adb74
Score 71.5835% 71.5835% (0)

@therealdreg therealdreg requested a review from hugsy April 23, 2024 18:57
@therealdreg therealdreg self-assigned this Apr 23, 2024
@therealdreg therealdreg added this to the 2024.05 milestone Apr 23, 2024
hugsy
hugsy requested changes Apr 23, 2024
View reviewed changes
@therealdreg therealdreg requested a review from hugsy April 23, 2024 20:20
@github-actions GitHub Actions
Copy link

🤖 Coverage update for a91ed8c 🟢

Old New
Commit 8031fda a91ed8c
Score 71.5835% 71.5835% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for dbaacb2 🟢

Old New
Commit 92f45ba dbaacb2
Score 71.5835% 71.5835% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for e93eff9 🟢

Old New
Commit 92f45ba e93eff9
Score 71.5835% 71.6215% (0.038)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 67fd29a 🟢

Old New
Commit 92f45ba 67fd29a
Score 71.5835% 71.5835% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for fbbd1ba 🟢

Old New
Commit 92f45ba fbbd1ba
Score 71.5835% 71.5835% (0)

@therealdreg
Copy link
Collaborator Author

done! @hugsy take a look!

hugsy
hugsy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, super clear

@hugsy hugsy added documentation ui Anything related to GEF's appearance and removed bug labels Apr 26, 2024
@hugsy hugsy merged commit 29fb74e into hugsy:main Apr 26, 2024
6 checks passed
@therealdreg therealdreg deleted the add-layout-mapping-API-for-extenal-plugins branch April 26, 2024 18:17
therealdreg added a commit to hugsy/gef-extras that referenced this pull request Apr 27, 2024
@therealdreg
add new API pane for glibc and syscalls (#111)
9d7ff6f 
This fixes all the issues with the context panes and it now works as it
did before the plugins were created.

In the GEF part, it was just a minor refactor and a new external API. 

In the gef-extras part, it was only necessary to call this new function!

I think the proposed solution is simple and it works.

gef code:
- hugsy/gef#1093
@therealdreg therealdreg mentioned this pull request Apr 27, 2024
Closed
mahaloz added a commit to mahaloz/gef that referenced this pull request Jul 18, 2024
@mahaloz
Fix an incorrect scoped function call (introduced in hugsy#1093)
2066ca0
@mahaloz mahaloz mentioned this pull request Jul 18, 2024
Merged
4 tasks
Grazfather pushed a commit that referenced this pull request Jul 21, 2024
@mahaloz
Fix an incorrect scoped function call (introduced in #1093) (#1124)
d8c7723 
```
Python Exception <class 'NameError'>: name 'add_context_layout_mapping' is not defined
Error occurred in Python: name 'add_context_layout_mapping' is not defined
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugsy hugsy hugsy approved these changes

Assignees

@therealdreg therealdreg

Labels
documentation ui Anything related to GEF's appearance
Projects
None yet
Milestone
2024.06
Development

Successfully merging this pull request may close these issues.
2 participants
@therealdreg @hugsy