Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GEF to a Python 3.10 baseline #1133

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Move GEF to a Python 3.10 baseline #1133

merged 10 commits into from
Sep 26, 2024
+24 −21

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Sep 7, 2024

Description

Fixes #1132

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added the tech debt label Sep 7, 2024
@hugsy hugsy added this to the 2024.09 milestone Sep 7, 2024
@hugsy hugsy self-assigned this Sep 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

🤖 Coverage update for f89db46 🟢

Old New
Commit 674c74d f89db46
Score 71.6267% 71.6506% (0.0239)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

🤖 Coverage update for f89db46 🟢

Old New
Commit 674c74d f89db46
Score 71.6267% 71.6267% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

🤖 Coverage update for 1b9b838 🟢

Old New
Commit 674c74d 1b9b838
Score 71.6267% 71.6319% (0.0052)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

🤖 Coverage update for 1b9b838 🟢

Old New
Commit 674c74d 1b9b838
Score 71.6267% 71.6267% (0)

@hugsy hugsy mentioned this pull request Sep 24, 2024
Merged
Grazfather
Grazfather reviewed Sep 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

🤖 Coverage update for df9f54b 🟢

Old New
Commit 674c74d df9f54b
Score 71.6267% 71.6267% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for df9f54b 🟢

Old New
Commit 674c74d df9f54b
Score 71.6267% 71.6319% (0.0052)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 2de8880 🟢

Old New
Commit 674c74d 2de8880
Score 71.6267% 71.6267% (0)

@hugsy @Grazfather
Update docs/install.md
fe3cc57 
Co-authored-by: Grazfather <[email protected]>
@github-actions GitHub Actions
Copy link

🤖 Coverage update for fe3cc57 🟢

Old New
Commit 674c74d fe3cc57
Score 71.6267% 71.6267% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 2de8880 🟢

Old New
Commit 674c74d 2de8880
Score 71.6267% 71.6319% (0.0052)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for fe3cc57 🟢

Old New
Commit 674c74d fe3cc57
Score 71.6267% 71.6506% (0.0239)

@hugsy hugsy requested a review from Grazfather September 25, 2024 15:26
@hugsy hugsy merged commit 115137c into main Sep 26, 2024
6 checks passed
@hugsy hugsy mentioned this pull request Sep 26, 2024
Open
8 tasks
@hugsy hugsy deleted the move_gef_to_py310_base branch September 26, 2024 04:28
ValekoZ pushed a commit that referenced this pull request Nov 10, 2024
@hugsy
Python 3.10 improvements (#1139)
0f21eea 
## Description

Follow-up PR for #1133 but purely esthetic, no functional changes

Cleans up the code to make it more in comformance with Python 3.10
capabilities.

Replaces:
 - type `Union` with `|`
 - type `Dict`/`Set`/`List`/`Tuple` with `dict`/`set`/`list`/`tuple`
 - `Optional` with ` | None`
 - `if:` ... `elif`... -> `match`

Fixes: 
 - `gdb.events.*Event` -> `gdb.*Event`
- `GefHeapManager.malloc_align_address` had its `ceil` lambda moved as a
proper (nested) function

Lint:
 - `except:` -> `except Exception:`
 - removed a bunch of unused f-strings
 - `if not .. in ..` -> `if .. not in ..`
 - some short named variables renamed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@daniellimws daniellimws Awaiting requested review from daniellimws

@therealdreg therealdreg Awaiting requested review from therealdreg

@ValekoZ ValekoZ Awaiting requested review from ValekoZ

@theguy147 theguy147 Awaiting requested review from theguy147

Assignees

@hugsy hugsy

Labels
tech debt
Projects
None yet
Milestone
2025.01
Development

Successfully merging this pull request may close these issues.

Move GEF to Python 3.10 baseline
2 participants
@hugsy @Grazfather