Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for release 2025.01 #1164

Merged
merged 2 commits into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI Coverage for PR
name: Coverage

on:
pull_request_target:
Expand All @@ -14,16 +14,18 @@ jobs:
coverage:
env:
PY_VER: ''
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup
run: |
sudo apt-get -qq update
sudo apt-get -qq install -y gdb-multiarch python3-dev python3-pip python3-wheel python3-setuptools git cmake gcc g++ pkg-config libglib2.0-dev gdbserver qemu-user curl
sudo python3 -m pip install --upgrade pip --quiet
- name: Run test coverage
export NEEDRESTART_MODE=n
sudo apt-get update -qq
sudo apt-get install -qq -y gdb-multiarch python3-dev python3-pip python3-wheel python3-setuptools git cmake gcc g++ pkg-config libglib2.0-dev gdbserver qemu-user curl
sudo apt-get install -y python3-full

- name: Run coverage
id: get_coverage
env:
ALLOWED_MARGIN: 0.01
Expand All @@ -41,7 +43,7 @@ jobs:
echo "current_score=${current_score}" >> $GITHUB_OUTPUT
echo "score_diff=${score_diff}" >> $GITHUB_OUTPUT

- name: Post comment
- name: Post results
uses: actions/github-script@v7
with:
script: |
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2013-2024 crazy rabbidz
Copyright (c) 2013-2025 crazy rabbidz

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ try to reach out for help on the Discord channel or submit an issue.

| Documentation |License | Compatibility | CI Tests (`main`) |
|:---:|:---:|:---|--|
| [![Documentation](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml) | [![MIT](https://img.shields.io/packagist/l/doctrine/orm.svg?maxAge=2592000?style=plastic)](https://github.com/hugsy/gef/blob/main/LICENSE) | [![Python 3](https://img.shields.io/badge/Python-3-green.svg)](https://github.com/hugsy/gef/) | [![CI Test for GEF](https://github.com/hugsy/gef/actions/workflows/run-tests.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/run-tests.yml) |
| [![Documentation](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml) | [![MIT](https://img.shields.io/packagist/l/doctrine/orm.svg?maxAge=2592000?style=plastic)](https://github.com/hugsy/gef/blob/main/LICENSE) | [![Python 3](https://img.shields.io/badge/Python-3-green.svg)](https://github.com/hugsy/gef/) | [![CI Test for GEF](https://github.com/hugsy/gef/actions/workflows/tests.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/tests.yml) |

## Contribute

Expand Down
8 changes: 4 additions & 4 deletions gef.py
Original file line number Diff line number Diff line change
Expand Up @@ -3703,7 +3703,7 @@ def new_objfile_handler(evt: "gdb.NewObjFileEvent | None") -> None:
if evt:
path = evt.new_objfile.filename or ""
elif progspace:
path = progspace.filename
path = progspace.filename or ""
else:
raise RuntimeError("Cannot determine file path")
try:
Expand Down Expand Up @@ -4901,7 +4901,7 @@ def do_invoke(self, argv: list[str]) -> None:

try:
git = which("git")
except:
except FileNotFoundError:
git = None

if git:
Expand Down Expand Up @@ -11403,7 +11403,7 @@ def file(self) -> pathlib.Path | None:
return self.remote.file
progspace = gdb.current_progspace()
assert progspace
fpath: str = progspace.filename
fpath: str = progspace.filename or ""
if fpath and not self._file:
self._file = pathlib.Path(fpath).expanduser()
return self._file
Expand Down Expand Up @@ -11547,7 +11547,7 @@ def file(self) -> pathlib.Path:
if not filename:
raise RuntimeError("No session started")
start_idx = len("target:") if filename.startswith("target:") else 0
self._file = pathlib.Path(progspace.filename[start_idx:])
self._file = pathlib.Path(filename[start_idx:])
return self._file

@property
Expand Down
Loading