Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat / core changes for v2.4 release #403

Draft
wants to merge 92 commits into
base: development
Choose a base branch
from
Draft

Conversation

fengtality
Copy link
Contributor

@fengtality fengtality commented Jan 31, 2025

A description of the changes proposed in the pull request:

  • Meteora connector in new route structure
  • Fastify-based CLMM schemas
  • Fastify-based Swap schemas
  • Fastify-based error handling
  • Raydium CLMM connector in new route structure
  • Raydium AMM connector in new route structure

Expected in next releases

  • Fastify-based Chain schemas
  • Jupiter Swap connector in new route structure
  • Solana Chain connector in new route structure
  • Uniswap CLMM connector in new route structure
  • Uniswap AMM connector in new route structure
  • Ethereum Chain connector in new route structure

@nikspz
Copy link
Contributor

nikspz commented Feb 13, 2025

commit 22eaca4

Gateway - no reconnection after update to new NodeURL during gateway connect #409

image

@nikspz
Copy link
Contributor

nikspz commented Feb 14, 2025

commit b323da0
Failed to connect jupiter_solana_mainnet-beta

Steps:
0. Update nodeURL for solana

  1. Clone latest development + gwPR403
  2. review gateway ONLINE
  3. gateway connect jupiter_solana_mainnet-beta
    Actual:
    review ERROR - Unhandled error in background task: 'SWAP'
    failed to connect and check balance

logs_hummingbot.log

2025-02-14 14:17:08,555 - 639568 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'SWAP'
Traceback (most recent call last):
  File "/home/hummingbot/nikita/development1/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/hummingbot/nikita/development1/hummingbot/client/command/gateway_command.py", line 397, in _gateway_connect
    AllConnectorSettings.create_connector_settings()
  File "/home/hummingbot/nikita/development1/hummingbot/client/settings.py", line 429, in create_connector_settings
    type=ConnectorType[connection_spec["trading_type"]],
  File "/home/hummingbot/miniconda3/envs/hummingbot/lib/python3.10/enum.py", line 440, in __getitem__
    return cls._member_map_[name]
KeyError: 'SWAP'

image
image

@rapcmia
Copy link
Contributor

rapcmia commented Feb 17, 2025

PR update:

  • Setup fresh install on ubuntu24.04
    # node version 20 or higher
    # npm install -g pnpm
    1. pnpm install
    2. pnpm build
    3. pnpm run setup
    4. pnpm link --global
       - useful when setting up gateway for the first time
          - if user have to reinstall to a different folder, have to use it again
       - On some instances, user have to:
          - `pnpm setup` then `source ~/.bashrc` or equilvalent shell like `./zshrc`
    6. gateway start --passphrase=
     - For API tests, add suffix `--dev`
    
  • When starting gateway, getting error bigint: failed to load bindings, pure JS will be used (try npm run rebuild?
    image
    • Tried to pnpm build or redo installation still same result
  • Able to run fastify using gateway start --passphrase=a --dev
    • Found an instance which does not let me access my fastify when setting up remotely returning blank page
      image
      • Running API tests on localhost works 100% all the time ✅
  • Reproduce @nikspz reported issue on Unhandled error in background task: SWAP
    image
    2025-02-17 17:17:29,360 - 35092 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'SWAP'
    Traceback (most recent call last):
      File "/home/rapcomia/hummingbot/hummingbot/dev-hummingbot/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
        return await c
      File "/home/rapcomia/hummingbot/hummingbot/dev-hummingbot/hummingbot/client/command/gateway_command.py", line 397, in _gateway_connect
        AllConnectorSettings.create_connector_settings()
      File "/home/rapcomia/hummingbot/hummingbot/dev-hummingbot/hummingbot/client/settings.py", line 429, in create_connector_settings
        type=ConnectorType[connection_spec["trading_type"]],
      File "/home/rapcomia/miniconda3/envs/hummingbot/lib/python3.10/enum.py", line 440, in __getitem__
        return cls._member_map_[name]
    KeyError: 'SWAP'
    
    • Tried to relaunch hummingbot, this error does not allow us to open the client
      image
      • Workaround is to delete ./conf/gateway_connections.json however when adding AMM connectors, issue reoccurs
  • Found another bug that gateway does not reconnect after config is updated ❌
    image
    • On screenshot, observed ELIFECYCLE command failed with exit code 1
    • Same behavior when updating nodeURL when setting up connector
    • Eventually will return an error of cannot connect to localhost:15888
    • Issue does not occur on development hummingbot + gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

3 participants