You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when running warp apply, the function eventually calls EvmERC20WarpModule.updateExistingHook(), which initializes the EvmHookModule with the actualConfig.hook.
When hookModule.update(expectedConfig.hook!) is called, await this.read() is also called, which derives the hookConfig again.
Since the hookConfig was previously derived by the WarpModule, this is extra work. This is problematic with large hook configs such as the Mailbox's default hook, which adds significant time to warp apply and potentially other future updates (core apply).
Solution
Consider updating the HookModule to store the actualConfig and assume that this is derived previously and return this in the read()
The text was updated successfully, but these errors were encountered:
Problem
Currently when running
warp apply
, the function eventually callsEvmERC20WarpModule.updateExistingHook()
, which initializes theEvmHookModule
with theactualConfig.hook
.hyperlane-monorepo/typescript/sdk/src/token/EvmERC20WarpModule.ts
Lines 523 to 528 in 4383086
When
hookModule.update(expectedConfig.hook!)
is called,await this.read()
is also called, which derives thehookConfig
again.Since the
hookConfig
was previously derived by the WarpModule, this is extra work. This is problematic with large hook configs such as the Mailbox's default hook, which adds significant time towarp apply
and potentially other future updates (core apply).Solution
actualConfig
and assume that this is derived previously and return this in theread()
The text was updated successfully, but these errors were encountered: