Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize hook module read in warp apply process by using provide… #5541

Open
wants to merge 3 commits into
base: refactor/consolidate-warp-route-updates
Choose a base branch
from

Conversation

mshojaei-txfusion
Copy link
Collaborator

@mshojaei-txfusion mshojaei-txfusion commented Feb 21, 2025

Description

This PR simplifies the hook module read functionality by removing the EvmHookReader class and its associated complexity. The changes include:

  1. Removal of the EvmHookReader import and instance in EvmHookModule
  2. Simplification of the read() method to directly return the config
  3. Reordering of config update in the update() method to ensure proper comparison

These changes make the code more maintainable and reduce unnecessary complexity while maintaining the same functionality.

Drive-by changes

  • Reordered the config update in the update() method to happen after normalization comparison

Related issues

Backward compatibility

Yes - These changes are backward compatible. The functionality remains the same, we're just simplifying the implementation. No infrastructure implications as this is a refactoring of the internal SDK code.

Testing

Manual - The changes have been tested manually to ensure the hook module read and update functionality works as expected. The changes are minimal and focused on internal implementation details.

Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: 8100621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mshojaei-txfusion mshojaei-txfusion changed the base branch from refactor/consolidate-warp-route-updates to main February 21, 2025 14:18
@mshojaei-txfusion mshojaei-txfusion changed the base branch from main to refactor/consolidate-warp-route-updates February 21, 2025 14:39
@mshojaei-txfusion mshojaei-txfusion changed the base branch from refactor/consolidate-warp-route-updates to main February 21, 2025 15:08
@mshojaei-txfusion mshojaei-txfusion changed the base branch from main to refactor/consolidate-warp-route-updates February 21, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant