fix: optimize hook module read in warp apply process by using provide… #5541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the hook module read functionality by removing the
EvmHookReader
class and its associated complexity. The changes include:EvmHookReader
import and instance inEvmHookModule
read()
method to directly return the configupdate()
method to ensure proper comparisonThese changes make the code more maintainable and reduce unnecessary complexity while maintaining the same functionality.
Drive-by changes
update()
method to happen after normalization comparisonRelated issues
Backward compatibility
Yes - These changes are backward compatible. The functionality remains the same, we're just simplifying the implementation. No infrastructure implications as this is a refactoring of the internal SDK code.
Testing
Manual - The changes have been tested manually to ensure the hook module read and update functionality works as expected. The changes are minimal and focused on internal implementation details.