chore: Clean up getters #5316
Merged
chore: Clean up getters #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltyu
requested review from
tkporter,
paulbalaji and
Mo-Hussain
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5316 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
|
ltyu
commented
Jan 28, 2025
...ipt/infra/config/environments/mainnet3/warp/configGetters/getEthereumSeiPumpBTCWarpConfig.ts
Show resolved
Hide resolved
nambrot
reviewed
Jan 28, 2025
...ipt/infra/config/environments/mainnet3/warp/configGetters/getEthereumVictionETHWarpConfig.ts
Outdated
Show resolved
Hide resolved
paulbalaji
approved these changes
Jan 29, 2025
ltyu
added a commit
to hyperlane-xyz/hyperlane-registry
that referenced
this pull request
Jan 29, 2025
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-registry
that referenced
this pull request
Jan 29, 2025
### Description Update configs according to hyperlane-xyz/hyperlane-monorepo#5316, which moves ownerOverride to its own proxyAdmin. Reverts removal of ownerOverride for some routes. ### Backward compatibility Yes
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-registry
that referenced
this pull request
Jan 29, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @hyperlane-xyz/[email protected] ### Minor Changes - 9649368: Add metadata.json and logos for sSOL, USD\*, and SONIC - c5ca52b: Addng chronicleyellowstone chain metadata ### Patch Changes - f8903b4: Update configs according to <hyperlane-xyz/hyperlane-monorepo#5316>, which moves ownerOverride to its own proxyAdmin. Reverts removal of ownerOverride for some routes. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to clean up getters to create configs that do not include unused fields.
For example, the
ownerOverrideswith all the extra fields:https://github.com/hyperlane-xyz/hyperlane-registry/blob/83cd45dba92a56d0b418b5941bb88d4fe0b04c65/deployments/warp_routes/ETH/ethereum-viction-deploy.yaml#L1-L12
The resulting configs https://github.com/hyperlane-xyz/hyperlane-registry/pull/530/files
Related issues
Backward compatibility
Yes
Testing