refactor: optional mailbox on warp config #5500
Open
+75
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshojaei-txfusion
requested review from
yorhodes,
ltyu and
paulbalaji
as code owners
🦋 Changeset detectedLatest commit: 2ec2f6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mshojaei-txfusion
changed the title
nambrot
reviewed
Feb 21, 2025
| config = await fillDefaults(context, config as any); | ||
|
|
||
| //fillDefaults would have added a mailbox to the config if it was missing | ||
| return WarpRouteDeployConfigSchema.parse( |
There was a problem hiding this comment.
Can we not use WarpRouteDeployConfigMailboxRequired to parse then to avoid the type cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the warp route deployment configuration to handle mailbox addresses more consistently. Key changes:
Drive-by changes
Related issues
#5258
Backward compatibility
Yes - This change maintains backward compatibility while improving the internal handling of mailbox addresses.
Testing
Unit Tests - Existing tests have been updated to accommodate the new mailbox handling approach