Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli verify function update #5516

Open
wants to merge 2 commits into
base: ccip-warp-route
Choose a base branch
from

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Feb 19, 2025

Description

This PR moves the logic related to fetching constructor args and verifying the warp route contract to its own helper file. It also parameterizes getContractFactoryAndName to allow the caller to specify which factory contracts to use.

The reason this is done is to enable hyperlane hook verify in this PR #5512

Yes

Testing

Manual

@ltyu ltyu requested a review from yorhodes as a code owner February 19, 2025 02:54
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 1066a0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ltyu ltyu changed the title Ltyu/cli verify update feat: cli verify function update Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (81ea6cc) to head (1066a0c).

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5516   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <ø> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant