-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cosmos RPC failure / success metrics and alerts #5523
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5523 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
Description
add cosmos RPC failure / success metrics and alerts)
RPC
For RPC clients, I added a wrapper function around each call.
This works out better because the HttpClient from tendermint's sdk is not very extensible, and most of the methods require us to manually provide the method metric.
GRPC
For GRPC, I added a wrapper around Tonic's Channel, inspired by code from https://docs.rs/tonic_prometheus_layer/0.1.11/tonic_prometheus_layer/
Drive-by changes
Related issues
#5252
Backward compatibility
Testing