Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bridge if bufferCap is set to 0 #5538

Open
wants to merge 2 commits into
base: ccip-warp-route
Choose a base branch
from

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Feb 21, 2025

Description

Removes a bridge when the buffer cap is set to 0

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: eebce48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji changed the title Remove bridge if bufferCap is set to 0 feat: remove bridge if bufferCap is set to 0 Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (8238595) to head (eebce48).
Report is 1 commits behind head on ccip-warp-route.

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5538   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <ø> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

@Mo-Hussain
Copy link
Contributor

Mo-Hussain commented Feb 21, 2025

Is the intention to merge this change? Could there be cases where we may want to temporarily set the limit to zero? In which case removing the bridge may not be desirable.

Another other way to handle something like could be to add an enabled boolean field in the xERC20 object on the deploy config. We could then have a single script that add/removes bridges based on that value

@nambrot
Copy link
Contributor Author

nambrot commented Feb 21, 2025

@Mo-Hussain yes we have to remove the bridge because the contract won't let us set the limits to 0, we tried that and 1 wei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants