-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove bridge if bufferCap is set to 0 #5538
base: ccip-warp-route
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ccip-warp-route #5538 +/- ##
================================================
Coverage 77.11% 77.11%
================================================
Files 109 109
Lines 2163 2163
Branches 193 193
================================================
Hits 1668 1668
Misses 474 474
Partials 21 21
|
Is the intention to merge this change? Could there be cases where we may want to temporarily set the limit to zero? In which case removing the bridge may not be desirable. Another other way to handle something like could be to add an |
@Mo-Hussain yes we have to remove the bridge because the contract won't let us set the limits to 0, we tried that and 1 wei |
Description
Removes a bridge when the buffer cap is set to 0