chore: fix shellcheck lints #25956
Merged
chore: fix shellcheck lints #25956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erratic-pattern
commented
Feb 3, 2025
install_influxdb3.sh
Outdated
| @@ -331,7 +332,7 @@ if [ "${EDITION}" = "Core" ]; then | |||
| printf "├─${DIM} Node ID: %s${NC}\n" "$NODE_ID" | |||
| printf "├─${DIM} Storage: %s${NC}\n" "$STORAGE_TYPE" | |||
| printf "├─${DIM} '%s' serve --node-id='%s' --http-bind='0.0.0.0:%s' %s${NC}\n" "$INSTALL_LOC/$BINARY_NAME" "$NODE_ID" "$PORT" "$STORAGE_FLAGS_ECHO" | |||
| "$INSTALL_LOC/$BINARY_NAME" serve --node-id="$NODE_ID" --http-bind="0.0.0.0:$PORT" $STORAGE_FLAGS > /dev/null & | |||
| "$INSTALL_LOC/$BINARY_NAME" serve --node-id="$NODE_ID" --http-bind="0.0.0.0:$PORT" "$STORAGE_FLAGS" > /dev/null & | |||
There was a problem hiding this comment.
erratic-pattern
commented
Feb 3, 2025
| @@ -4,7 +4,7 @@ set -eu -o pipefail | |||
|
|
|||
| args=( "$@" ) | |||
| for i in "${!args[@]}"; do | |||
| args[$i]="$(echo "${args[$i]}" | envsubst)" | |||
| args[i]="$(echo "${args[$i]}" | envsubst)" | |||
There was a problem hiding this comment.
erratic-pattern
requested review from
hiltontj,
peterbarnett03 and
mgattozzi
hiltontj
approved these changes
Feb 12, 2025
Removed all of the shellcheck complaints that were showing up in my editor. Where possible, I just fixed them directly but I just told it to ignore this one in the install scripts https://www.shellcheck.net/wiki/SC2059 Happy to go and fix that lint too I just wasn't sure if we prefer the current approach, since it doesn't seem to be causing any problems.
erratic-pattern
force-pushed
the
adam/fix-shellcheck-lints
branch
from
360b87c to
07da4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all of the shellcheck complaints that were showing up in my editor.
Where possible, I just fixed them directly but I just told it to ignore this one in the install scripts https://www.shellcheck.net/wiki/SC2059
Happy to go and fix that lint too I just wasn't sure if we prefer the current approach, since it doesn't seem to be causing any problems.