fix: serialize distinct cache in catalog #25990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distinct cache info for tables was not serialized in the catalog. This fixes it, but also updates the catalog serialization to use the snapshot type serialization from the Catalog type all the way down. The Eq and PartialEq impls were removed from Catalog and InnerCatalog as they were only used in tests, and wer replaced by pure insta snapshot tests. A test was added to check that the distinct cache serializes/deserializes
hiltontj
force-pushed
the
hiltontj/catalog-serde
branch
from
b0d6d6d to
fe53e4e
Compare
hiltontj
commented
Feb 11, 2025
| let deserialized = Catalog::from_inner(deserialized_inner); | ||
| assert_eq!(catalog, deserialized); | ||
| assert_eq!(instance_id, deserialized.instance_id()); | ||
| insta::allow_duplicates! { |
There was a problem hiding this comment.
This is a neat feature in insta that allows you to make the same snapshot assertion twice, and it checks the result against the same snapshot file. I used it here to check roundtrip serialization/deserialization.
pauldix
approved these changes
Feb 11, 2025
This was referenced Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinct cache info for tables was not serialized in the catalog. This fixes that, but also updates the catalog serialization to use the same snapshot pattern for serialization from the Catalog type all the way down. This removes the need to serialize the
db_mapfrom the catalog.The Eq and PartialEq derives were removed from Catalog and InnerCatalog as they were only used in tests, where assertions using them were replaced by insta snapshot tests.
A test was added to check serialization/deserialization of distinct caches in the catalog.
There is no issue for this.