-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(processing_engine): improve package management for standalone python. #26027
base: main
Are you sure you want to change the base?
Conversation
@jacksonrnewhouse - I'm taking that to mean only the docker images on OSX. Is this PR expected to also help with non-docker images built with python standalone where the python directory is a subdir under the binary? Eg:
https://github.com/influxdata/influxdb/blob/main/README_processing_engine.md#local-development-with-python-build-standalone has more info. |
@jacksonrnewhouse - I like the idea of adjusting the build to set the paths at build rather than runtime. Let's sync up on this and discuss how you want things to look long term. Since I think those changes will be more substantial, in the interest of time, I created #26029 to address the venv issues I left open when #25969 was committed. It simply builds a little bit on the runtime setup to remove the regressions quickly and give some breathing room on designing the proper solution for how you want the paths setup. |
Ok, various PRs have landed and #26042 adds some cleanup that altogether MAY be enough for the immediate term (and thus you can close this PR), but I still think adjusting the build to set the paths at build rather than runtime is a good idea. Like before, let's sync up on this and discuss how you want things to look long term. |
80a4c71
to
9012345
Compare
@jacksonrnewhouse - should this be closed in favor of recent merges, #26047 and the discussions we had yesterday? |
This adds another package manager specifically for standalone python. I also added a default plugin dir in the docker image of /plugin, as folks had had permissions issues with our existing images, particularly on docker.
You can now run the docker image without any additional arguments and it'll run a plugin manager using the standalone python.
@jdstrand, I've only tested the images on OS X, but I don't think this will cause any issues on other platforms.