Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to Rust 1.85 and 2024 Edition #26046

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

mgattozzi
Copy link
Contributor

These changes make no actual change to the code beyond the following:

  • Functions like set_env are now marked unsafe. In reality they always were. Many functions now require unsafe blocks in 2024 edition.
  • Additionally functions marked unsafe now require all unsafe function calls inside them to use unsafe blocks. Before that was not needed.
  • Clippy and Rust 2024 Edition fixes
  • rustfmt 2024 edition formatting changes

Besides that code should function the exact same way!

These changes make no actual change to the code beyond the following:

- Functions like set_env are now marked unsafe. In reality they always
  were. Many functions now require unsafe blocks in 2024 edition.
- Additionally functions marked unsafe now require all unsafe function
  calls inside them to use unsafe blocks. Before that was not needed.
- Clippy and Rust 2024 Edition fixes
- rustfmt 2024 edition formatting changes

Besides that code should function the exact same way!
Copy link
Contributor

@hiltontj hiltontj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for picking this up. LGTM.

@mgattozzi mgattozzi merged commit 1f72bfc into main Feb 20, 2025
12 checks passed
@mgattozzi mgattozzi deleted the mgattozzi/2024-edition branch February 20, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants