-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for null baseline_sha #72
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 154 154
Branches 6 6
=========================================
Hits 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use just a 40-character placeholder string like "z" * 40
?
The schema checks for a valid sha here:
|
@dberenbaum is it still relevant? |
It depends on how we decide to go with issues like iterative/dvclive#638 and iterative/dvclive#237. If we decide to clone the repo on every node where dvclive runs, then this won't be needed, but if we decided to allow for some "no-git" scenarios, I think it might be needed. I can convert to draft until we decide. |
Needed for iterative/dvclive#646 to work without a baseline revision (since this would be a pain to provide in a no-git scenario).
@daavoo I will likely need your help to make similar changes on the Studio side to accept requests with missing
baseline_sha
.