Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optuna: Use summary instead of log_metric. #514

Merged
merged 1 commit into from
Apr 3, 2023
Merged

optuna: Use summary instead of log_metric. #514

merged 1 commit into from
Apr 3, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Apr 3, 2023

Prevent creation of single-row .tsv files.

Each trial creates a single DVC experiment and logs metrics a single time.

Prevent creation of single-row `.tsv` files.

Each trial creates a single DVC experiment and logs metrics a single time.
@daavoo daavoo added A: frameworks Area: ML Framework integration enhancement labels Apr 3, 2023
@daavoo daavoo requested a review from dberenbaum April 3, 2023 09:38
@daavoo daavoo self-assigned this Apr 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (634f911) 95.70% compared to head (e6c402c) 95.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   95.70%   95.71%           
=======================================
  Files          41       41           
  Lines        2587     2588    +1     
  Branches      220      220           
=======================================
+ Hits         2476     2477    +1     
  Misses         66       66           
  Partials       45       45           
Impacted Files Coverage Δ
src/dvclive/optuna.py 66.66% <100.00%> (ø)
tests/test_frameworks/test_optuna.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit c9fe84d into main Apr 3, 2023
@daavoo daavoo deleted the optuna-summary branch April 3, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: frameworks Area: ML Framework integration enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants