Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json: use indent #78

Merged
merged 1 commit into from
May 18, 2021
Merged

json: use indent #78

merged 1 commit into from
May 18, 2021

Conversation

pared
Copy link
Contributor

@pared pared commented May 18, 2021

Related to #75

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e923b1a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #78   +/-   ##
=========================================
  Coverage          ?   80.97%           
=========================================
  Files             ?        9           
  Lines             ?      226           
  Branches          ?        0           
=========================================
  Hits              ?      183           
  Misses            ?       43           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e923b1a...6b5f1a9. Read the comment docs.

@pared pared force-pushed the 75_format_json branch from 6cb924d to 6b5f1a9 Compare May 18, 2021 12:01
dberenbaum
dberenbaum approved these changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dvclive/keras.py
@@ -1,4 +1,6 @@
from tensorflow.keras.callbacks import Callback
from tensorflow.keras.callbacks import ( # pylint: disable=no-name-in-module
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a weird change, but I'm guessing it's auto formatting? 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it started to occur recently, probably its some new rule for pylint. I need to research it, but don't want to block smaller changes.

@pared pared merged commit 657fbfa into master May 18, 2021
@pared pared mentioned this pull request Jun 1, 2021
Closed
@daavoo daavoo deleted the 75_format_json branch July 14, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pared @codecov-commenter @dberenbaum