fix(studio): package data to send in main thread #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
force-pushed
the
fix-858/race-condition-studio-update
branch
2 times, most recently
from
d34234a to
79f16a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
+ Coverage 95.29% 95.35% +0.05%
==========================================
Files 55 55
Lines 3911 3979 +68
Branches 304 309 +5
==========================================
+ Hits 3727 3794 +67
Misses 138 138
- Partials 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shcheklein
force-pushed
the
fix-858/race-condition-studio-update
branch
from
79f16a2 to
ca0564e
Compare
|
@skshetry PTAL |
skshetry
reviewed
Jan 29, 2025
| plots_start_idx = {} | ||
| for name, plot in plots.items(): | ||
| num_points_sent = self._num_points_sent_to_studio.get(name, 0) | ||
| plots_to_send[name] = plot[num_points_sent:] |
There was a problem hiding this comment.
I see below that it did _cast_to_numbers before? Do we need that here?
skshetry
approved these changes
Jan 29, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes root cause of the #858. We'll still need another fix / research on why it was hanging.
There was a race condition since both (main and Studio updates) threads were reading / updating the same
liveinstance values simultaneously.It seems it might be happening if a training loop is faster then Studio API call (can be when we have a lot of images).
TODO
❗ I have followed the Contributing to DVCLive guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏