Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty scope doesn't fail PR lint action #228

Closed
wolfm89 opened this issue Mar 5, 2024 · 2 comments · Fixed by #251
Closed

Empty scope doesn't fail PR lint action #228

wolfm89 opened this issue Mar 5, 2024 · 2 comments · Fixed by #251

Comments

@wolfm89
Copy link

wolfm89 commented Mar 5, 2024

Expected Behavior

A PR with title feat(): My description should fail the action due to missing scope.
The conventional commit specification says:

A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):

This is also how it's implemented in many other checkers (https://github.com/conventional-changelog/commitlint/blob/28bac3ea619e010ce1a3dbd08502588138ef9b74/%40commitlint/rules/src/scope-empty.test.ts#L35) and regex definitions (https://gist.github.com/marcojahn/482410b728c31b221b70ea6d2c433f0c)

Current Behavior

PR action doesn't fail on empty scope.

Steps to Reproduce

Create a PR with title feat(): My description and run this action on it.

Logs

image

jef added a commit that referenced this issue Feb 12, 2025
jef added a commit that referenced this issue Feb 12, 2025
jef added a commit that referenced this issue Feb 12, 2025
@jef jef closed this as completed in #251 Feb 12, 2025
@jef
Copy link
Owner

jef commented Feb 12, 2025

Thank you bringing this up! I can't believe I missed this... It's now implemented 😁

@wolfm89
Copy link
Author

wolfm89 commented Feb 12, 2025

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants