Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapter titles to trickplay popup #5832

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

enter-a-random-username
Copy link
Contributor

@enter-a-random-username enter-a-random-username commented Jul 26, 2024

Changes
Add chapter name to Trickplay similar to chapter only

image

My CSS, but i think maybe a generic solution wants something else.

.chapterThumbText {
    font-size: 1.2rem;
}

.chapterThumbName {
    position: absolute;
    right: 0;
    top: 0;
    font-size: 1.2rem;
    bottom: 0;
    margin: 0.5rem;
}

Reason for CSS

  • At the moment the font size for the time is huge
  • Thumb size is configurable (at very small images this could be a problem - i use 480px and HDPI 240px on pixel density >= 2.0 )
  • Maybe some overflow hidden for very long chapter names
  • Maybe a uniform solution with normal chapter and trickplay would be nice

Closes #5395

@enter-a-random-username enter-a-random-username requested a review from a team as a code owner July 26, 2024 18:04
@gnattu
Copy link
Member

gnattu commented Jul 28, 2024

Thumb size is configurable (at very small images this could be a problem - i use 480px and HDPI 240px on pixel density >= 2.0 )

I think we should just hide this if the thumb size is small.

At the moment the font size for the time is huge

And I think the PR should include a change set the font size for this and this should not be part of the custom css if we are shipping this a part of the standard behavior.

@enter-a-random-username
Copy link
Contributor Author

Thumb size is configurable (at very small images this could be a problem - i use 480px and HDPI 240px on pixel density >= 2.0 )

I think we should just hide this if the thumb size is small.

At the moment the font size for the time is huge

And I think the PR should include a change set the font size for this and this should not be part of the custom css if we are shipping this a part of the standard behavior.

I do not plan to use custom CSS, but i think all bubbles (no-image, Chapters and Trickplay) should use the same style/layout.
That is the reason i didn't include any scss yet.

Here the current chapter image
image

Non image or trickplay has no chapter names as well
image

Not a fan of 2 lines for time and chapter. It hides a lot of content.

enter-a-random-username and others added 2 commits August 1, 2024 03:17
Co-authored-by: Dmitry Lyzo <[email protected]>
Co-authored-by: Dmitry Lyzo <[email protected]>
Copy link

sonarqubecloud bot commented Aug 1, 2024

@enter-a-random-username
Copy link
Contributor Author

enter-a-random-username commented Aug 1, 2024

@dmitrylyzo maybe add a PR for chapters and time only as well. Current state you need to wait for image generation. Always a fan of unified UI.

You will squash the commits on merge rebase or whatever you use?

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Aug 1, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 1, 2024
@thornbill thornbill changed the title Trickplay chapters Add chapter titles to trickplay popup Aug 1, 2024
@thornbill thornbill merged commit 1f1e9d5 into jellyfin:master Aug 1, 2024
11 checks passed
@enter-a-random-username enter-a-random-username deleted the trickplay branch August 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Trickplay and chapter names
4 participants