Refactor searches #476
Merged
Refactor searches #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete vectorized search
Closed
13 tasks
Remove paginator
|
I've settled to cap search results at 100 as I think it's a reasonable number. I doubt many people can't filter their search within 100 results. This also prevents long search time. |
…add tests for get endpoint
|
Oops I forgot to add some more unit tests, one sec |
yesterd3v
approved these changes
Dec 22, 2021
JJamesWWang
added a commit
to JJamesWWang/semesterly
that referenced
this pull request
Jan 14, 2022
Refactor searches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor searches app
Remove vectorized search
Remove pagination, replace with 100 search cap
Add unit tests
Other reformatting/restructuring changes
Tasks